Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose EditorInspector.edit to scripting #94603

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

aaronfranke
Copy link
Member

@aaronfranke aaronfranke commented Jul 22, 2024

Context: I tried to add export settings to a custom format defined in a GDScript plugin, like #79316, but I found that the edit function of EditorInspector was not exposed, so it was not possible. This PR exposes it. I have tested that this works correctly.

@aaronfranke aaronfranke added this to the 4.4 milestone Jul 22, 2024
@aaronfranke aaronfranke requested a review from a team as a code owner July 22, 2024 00:14
@raulsntos
Copy link
Member

We already have multiple edit_* methods exposed in EditorInterface. Are the already exposed APIs not sufficient for your use case?

@aaronfranke
Copy link
Member Author

@raulsntos They're not sufficient, because I don't want to edit in the main inspector, I want to edit in a separate inspector.

Screenshot 2024-07-21 at 9 20 49 PM

@aaronfranke aaronfranke requested a review from fire September 11, 2024 11:20
@aaronfranke aaronfranke requested a review from a team as a code owner October 2, 2024 22:19
@aaronfranke aaronfranke requested a review from a team as a code owner October 30, 2024 07:47
@Repiteo Repiteo merged commit 07af56b into godotengine:master Dec 16, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 16, 2024

Thanks!

@aaronfranke aaronfranke deleted the editor-insp-edit branch December 16, 2024 23:15
@akien-mga akien-mga changed the title Expose EditorInspector.edit to scripting Expose EditorInspector.edit to scripting Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants