Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollContainer: Fix RTL on follow focus #94621

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Giganzo
Copy link
Contributor

@Giganzo Giganzo commented Jul 22, 2024

Believe this should fix: #94620

@Giganzo Giganzo requested a review from a team as a code owner July 22, 2024 13:02
@AThousandShips AThousandShips added this to the 4.3 milestone Jul 22, 2024
@AThousandShips AThousandShips added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jul 22, 2024
Change right_margin to side_margin
@akien-mga akien-mga changed the title Fix rtl on follow focus ScrollContainer: Fix RTL on follow focus Jul 24, 2024
@akien-mga akien-mga merged commit 73bcfec into godotengine:master Jul 25, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@Giganzo Giganzo deleted the scroll-container-rtl-fix branch July 25, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:gui
Projects
None yet
5 participants