Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript: Fix false positive cases of ENUM_VARIABLE_WITHOUT_DEFAULT #94635

Merged
merged 1 commit into from
Jul 23, 2024
Merged

GDScript: Fix false positive cases of ENUM_VARIABLE_WITHOUT_DEFAULT #94635

merged 1 commit into from
Jul 23, 2024

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev added this to the 4.3 milestone Jul 22, 2024
@dalexeev dalexeev requested a review from a team as a code owner July 22, 2024 18:46
aaronfranke
aaronfranke approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, this fixes the bug.

@akien-mga akien-mga merged commit f6c7b00 into godotengine:master Jul 23, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the gds-fix-false-positive-enum-without-default branch July 23, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@aaronfranke aaronfranke aaronfranke approved these changes

Assignees
No one assigned
Labels
bug regression topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Incorrect warning about default value shows up for enum function parameters
3 participants
@dalexeev @akien-mga @aaronfranke