Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS export] Do not stop export on signing errors. #94677

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jul 23, 2024

See #94631, while main issue (missing arm64 folder) should be already fixed by #94518, we should not stop export process if signing failed, it's optional and warning should be enough.

@bruvzg bruvzg added this to the 4.3 milestone Jul 23, 2024
@bruvzg bruvzg marked this pull request as ready for review July 23, 2024 20:52
@bruvzg bruvzg requested a review from a team as a code owner July 23, 2024 20:52
@akien-mga akien-mga merged commit 693b69d into godotengine:master Jul 24, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants