Apply prefer_wayland only if no display driver is set
#94774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch any other display driver preference would be overridden.
|
I can confirm that this resolves the issue on Windows at least, when doing |
akien-mga
changed the title
prefer_wayland only if no display driver is set
akien-mga
approved these changes
Jul 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94755.
Before this patch any other display driver preference would be overridden.
Regarding the
display_driver = "default"line, it's there so that if the project uses Wayland andprefer_waylandis set to false the editor actually tries X11 first like I think the user would expect and the documentation implies.I think that this option should probably be improved in the first place but we're on a release candidate :gdsweat: