-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] Add check for argument name validity #94798
base: master
Are you sure you want to change the base?
Conversation
Will move to the arg check and add the vararg check to prevent issues with empty cases, will push once CI is done |
d8e12b8
to
81d043b
Compare
81d043b
to
51ac117
Compare
This is a good fix. I think the only thing that could be added is checking against reserved C++ keywords, but at least those should compile error for godot-cpp. |
C++ keywords are already sanitized in godot-cpp: |
51ac117
to
2f6e0fe
Compare
2f6e0fe
to
733f2f8
Compare
733f2f8
to
32433ae
Compare
32433ae
to
e362ae3
Compare
e362ae3
to
e63f1d6
Compare
Checks that all method and signal arguments have valid names
Checks that all method and signal arguments have valid names
See:
I'd say a check in unit tests should suffice, but we could add checks in the API dump as well but we'd need to add some more for class, method, and signal names etc., which would double with the unit tests so I'd say the unit tests should cover the API