Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document alternatives to some static Color methods #94879

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 28, 2024

@KoBeWi KoBeWi added this to the 4.3 milestone Jul 28, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner July 28, 2024 15:31
@AThousandShips
Copy link
Member

We should probably see about how to document this constructor properly, as it's overlooked due to some conversion details, but this is good as an initial step IMO

@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 28, 2024

Another thing is that there is no way to link to a constructor, like to methods and members.

@Mickeon
Copy link
Contributor

Mickeon commented Jul 28, 2024

There is, but it's not coded properly because it's not standard (it needs more parameters than just the constructor's name)

Both [constructor Color] and [operator Color] work partially. They only point to the first one in the list if I recall correctly, and fail the check on Github.

@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 28, 2024

Yeah I noticed the constructors have name field, but each one is named the same. Hence it's effectively not possible to utilize it in a useful way.

@akien-mga akien-mga merged commit 6d46399 into godotengine:master Jul 29, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the color_conjuring_tricks branch July 29, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants