Call restart_editor() in RUN_PROJECT_MANAGER
#94880
Merged
+11
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
Jul 28, 2024
Comment on lines
-3404
to
-3407
| if (!exec_base_dir.is_empty()) { | ||
| args.push_back("--path"); | ||
| args.push_back(exec_base_dir); | ||
| } |
There was a problem hiding this comment.
The --path was explicitly passed to Project Manager, no idea what for.
akien-mga
changed the title
restart_editor() in RUN_PROJECT_MANAGERrestart_editor() in RUN_PROJECT_MANAGER
akien-mga
approved these changes
Oct 4, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #85654
The duplicate code in
RUN_PROJECT_MANAGERbranch is replaced with a modifiedrestart_editor().Seems like the code did not set
exitingpreviously, so this might also fix some bugs.