Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically enable doNotStrip for dev builds #94887

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Automatically enable doNotStrip for dev builds #94887

merged 1 commit into from
Jul 30, 2024

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Jul 28, 2024

Fix the generate_apk build logic to automatically include doNotStrip when dev_build or debug_symbols are enabled

@m4gr3d m4gr3d added this to the 4.3 milestone Jul 28, 2024
akien-mga
akien-mga reviewed Jul 29, 2024
View reviewed changes
platform/android/SCsub Outdated Show resolved Hide resolved
@m4gr3d m4gr3d force-pushed the fix_generate_apk_for_dev_build branch 4 times, most recently from 289f7e6 to 98e2335 Compare July 29, 2024 13:38
@m4gr3d m4gr3d marked this pull request as ready for review July 29, 2024 13:39
@m4gr3d m4gr3d requested a review from a team as a code owner July 29, 2024 13:39
akien-mga
akien-mga reviewed Jul 29, 2024
View reviewed changes
platform/android/SCsub Outdated Show resolved Hide resolved
@m4gr3d @akien-mga
Fix the generate_apk logic when dev_build or debug_symbols are …
c1acddf 
…enabled

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
@m4gr3d m4gr3d force-pushed the fix_generate_apk_for_dev_build branch from 476e638 to c1acddf Compare July 29, 2024 13:49
@akien-mga akien-mga merged commit a92d7ed into godotengine:master Jul 30, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the fix_generate_apk_for_dev_build branch July 30, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:android topic:buildsystem
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@m4gr3d @akien-mga