Fix reimporting textures after changing import project settings #94975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #62271, #94357 removed a check which is necessary to reimport textures when relevant project settings have changed (e.g. which VRAM compression formats are enabled).
This reintroduces the check but further down, fixing #62271 differently by checking first if the
.importfile hasvalid=false, which is written when an import fails. This allows to prevent reimporting, and then still do the check for whether texture import settings warrant a reimport on a valid imported file.Testing project: testreimportbug.zip
object/compress.glbfails importing due to lacking Draco compression supportgodog-cutscene.jpgis used for a Sprite3D in the main scene so it should be detected as requiring VRAM Compression even if the.importfile is removed