Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global class cache file not present when no class name #94991

Merged

Conversation

Hilderin
Copy link
Contributor

This PR fixes an issue where the global_script_class_cache.cfg could be missing on disk when the project contains no scripts.

The original draft was #94540

I added save_global_classes at 2 places:

  • In EditorFileSystem::_update_script_classes when no scripts and the file does not exists on file.
  • In EditorFileSystem::_remove_invalid_global_class_names when global class names are removed at startup.

Also removed ScriptServer::get_global_class_cache_file_path() which is unused.

@Hilderin Hilderin requested a review from a team as a code owner July 31, 2024 21:02
@akien-mga akien-mga added this to the 4.3 milestone Jul 31, 2024
@akien-mga akien-mga merged commit 7e1b74b into godotengine:master Jul 31, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants