Fix project name cleared when browsing path #95062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
Aug 2, 2024
| @@ -370,6 +370,8 @@ void ProjectDialog::_browse_project_path() { | |||
| } else { | |||
| fdialog_project->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_DIR); | |||
| } | |||
|
|
|||
| hide(); | |||
There was a problem hiding this comment.
This fixes the exclusive window error.
There was a problem hiding this comment.
IMHO you should also show the dialog when quit the browser window? Otherwise when user cancel the fdialog_project they won't see the project_dialog anymore.
AThousandShips
approved these changes
Aug 2, 2024
KoBeWi
force-pushed
the
adding_random_arguments_for_good_measure
branch
from
c456368 to
30da21f
Compare
akien-mga
approved these changes
Aug 6, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95038