Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3D12: Avoid crash on exit #95074

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

RandomShaper
Copy link
Member

@RandomShaper RandomShaper commented Aug 2, 2024

An alternative would be just not to free the DLLs. There's some risk of the bug being reintroduced if new COM smart pointers are added, but for now this should do the trick. Another alternative would be to have a DLL handle wrapper (for RAII), but it's also a bit dirty to have to rely on the order of member destruction, despite being deterministic.

@RandomShaper RandomShaper added this to the 4.3 milestone Aug 2, 2024
@RandomShaper RandomShaper requested a review from a team as a code owner August 2, 2024 16:20
@RandomShaper RandomShaper requested a review from bruvzg August 2, 2024 16:20
@akien-mga akien-mga merged commit 32eb97f into godotengine:master Aug 8, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the d3d12_exit_crash branch August 8, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants