Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript: Revert multiple GDScriptCache related PRs #95085

Closed
wants to merge 1 commit into from

Conversation

Revert "GDScript: Fix common mismatched external parser errors"
This reverts commit 6e8fa6d.

Revert "GDScriptCache: Clear abandoned parser refs"
This reverts commit 86b23d0.

Revert "GDScript: Invalidate cached parser chain when reloading"
This reverts commit ffc0d09.

Revert "Fix mismatched external parser with binary exports"
This reverts commit c419b54.

Revert "GDScript: invalidate GDScriptParserRef when reloading"
This reverts commit 6b88c86.
@mihe
Copy link
Contributor

mihe commented Aug 2, 2024

I can confirm that this fixes the regression reported in #95076, and results in a memory timeline much like what was seen prior to #92616, at 9db1a96.

@akien-mga
Copy link
Member

Superseded by #95115, for now 🤞

@akien-mga akien-mga closed this Aug 6, 2024
@akien-mga akien-mga removed this from the 4.3 milestone Aug 6, 2024
@dalexeev dalexeev deleted the gds-cache-reverts branch August 6, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Severe performance regression when loading many GDScript files
4 participants