Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear TabBar tab close button's rect after it's hidden #95122

Merged

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented Aug 4, 2024

Fixes #95110.

Similar to #83296 (same but for close buttons).

@kleonc kleonc added bug topic:editor regression topic:gui cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Aug 4, 2024
@kleonc kleonc added this to the 4.3 milestone Aug 4, 2024
@kleonc kleonc requested a review from a team as a code owner August 4, 2024 10:04
Copy link
Member

@YeldhamDev YeldhamDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue.

@akien-mga akien-mga merged commit c81aa6e into godotengine:master Aug 6, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@kleonc kleonc deleted the tab_bar_clear_close_button_rect branch August 6, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release regression topic:editor topic:gui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor scene tabs do not close as expected when there are too many to fit the window
3 participants