Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use-after-free in FileAccess::exists #95311

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Fix use-after-free in FileAccess::exists #95311

merged 1 commit into from
Aug 9, 2024

Conversation

mihe
Copy link
Contributor

@mihe mihe commented Aug 9, 2024

Fixes #95310.

This adds a zeroing out of the PackedData singleton when it's destroyed, to ensure that any nullptr check, such as the one in FileAccess::exists, actually does what it's supposed to.

@mihe mihe requested a review from a team as a code owner August 9, 2024 01:35
@mihe mihe mentioned this pull request Aug 9, 2024
Closed
@Chaosus Chaosus added this to the 4.4 milestone Aug 9, 2024
@Chaosus Chaosus added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Aug 9, 2024
@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Aug 9, 2024
@akien-mga akien-mga modified the milestones: 4.4, 4.3 Aug 9, 2024
@akien-mga akien-mga merged commit c73ac74 into godotengine:master Aug 9, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@mihe mihe deleted the file-access-use-after-free branch August 9, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash topic:core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Use-after-free when closing editor while using GDExtension on Windows
3 participants
@mihe @akien-mga @Chaosus