Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure not to generate the compile_commands.json when not asked #95338

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

hakro
Copy link
Contributor

@hakro hakro commented Aug 9, 2024

Did not create an issue for this, as the fix is pretty simple.

Scons seems to always generate the compile_commands.json, regardless of whether the flag compiledb is set or not, and even with an explicit compiledb=no.

There are a whopping 3-4 seconds out of 6-10 seconds of build time saved on my machine when I don't need to recreate that file, which is pretty nice when iterating fast on small changes.

@hakro hakro requested a review from a team as a code owner August 9, 2024 17:45
@AThousandShips AThousandShips added this to the 4.4 milestone Aug 9, 2024
SConstruct Outdated Show resolved Hide resolved
@akien-mga
Copy link
Member

akien-mga commented Aug 9, 2024

I confirm the code was similar in 4.2, so this is a regression fix:

https://github.com/godotengine/godot/blob/3504c98c1233bbd2506e89ce46509bc79afaec17/SConstruct#L952L963

@akien-mga akien-mga modified the milestones: 4.4, 4.3 Aug 9, 2024
@akien-mga akien-mga merged commit 5ae8250 into godotengine:master Aug 12, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@hakro hakro deleted the no_is_no branch August 12, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants