Fix check in Object._ValidateProperty example
#95341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GDScript version above makes the `number` property read only whenever `is_number_editable` is false. ```gdscript func _validate_property(property: Dictionary): if property.name == "number" and not is_number_editable: property.usage |= PROPERTY_USAGE_READ_ONLY ``` The C# version is similar, but omits the negation, so the Number property is made read only whenever `is_number_editable` is true. This adds the negation to the C# example, making it match the GDScript example.
akien-mga
approved these changes
Aug 9, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GDScript version above makes the
numberproperty read only wheneveris_number_editableis false.The C# version is similar, but omits the negation, so the Number property is made read only whenever
is_number_editableis true.This adds the negation to the C# example, making it match the GDScript example.