Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileSystem not updated on file deletion #95533

Conversation

Hilderin
Copy link
Contributor

The issue was a regression from #93919. I removed the emission of the filesystem_changed signal in EditorFileSystem::update_files when is_scanning is true. When removing files in a large project, the scanning process can take a bit longer, enough to have the scanning_changes variable set to true when entering EditorFileSystem::update_files. I kept the if (!is_scanning()) condition for _process_update_pending to prevent the original issue; anyway, it's called at the end of the scanning process.

It's really difficult to reproduce. I had to be in debug mode with a couple of breakpoints in DependencyRemoveDialog::ok_pressed and EditorFileSystem::update_files to reproduce the problem.

@akien-mga
Copy link
Member

Ok I misspoke in #95526 (comment), this is the last PR we'll merge for 4.3.stable :D

@akien-mga akien-mga merged commit 33c30b9 into godotengine:master Aug 14, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Found a bug when deleting file in the filesystem
2 participants