Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crash after removing GraphEdit's connection layer #96309

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Prevent crash after removing GraphEdit's connection layer #96309

merged 1 commit into from
Oct 1, 2024

Conversation

Geometror
Copy link
Member

@Geometror Geometror commented Aug 30, 2024 •
edited
Loading

Closes #96289.

Adds a descriptive warning when you accidentally remove the connection layer plus some checks everywhere a crash could occur (not ideal, but at least it's safe).

@Geometror Geometror added bug crash regression topic:gui cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 30, 2024
@Geometror Geometror added this to the 4.4 milestone Aug 30, 2024
@Geometror Geometror requested a review from a team as a code owner August 30, 2024 01:17
@Geometror Geometror mentioned this pull request Aug 30, 2024
Closed
AThousandShips
AThousandShips approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but this makes sense to me

@akien-mga akien-mga merged commit f4af820 into godotengine:master Oct 1, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@dustdfg
Copy link
Contributor

dustdfg commented Oct 1, 2024

Every time I close the editor (with opened project) I see following warning:

WARNING: GraphEdit's connection_layer removed. This should not be done. If you like to remove all GraphElements from a GraphEdit node, do not simply remove all non-internal children but check their type since the connection layer has to be kept non-internal due to technical reasons.
     at: remove_child_notify (scene/gui/graph_edit.cpp:656)

@dustdfg dustdfg mentioned this pull request Oct 3, 2024
Closed
@Geometror
Copy link
Member Author

Needs to be cherry-picked together with #96309.

@jamie-pate jamie-pate mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release crash regression topic:gui
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

C# Editor Plugin crashes Godot 4.3 when GraphNode is added to GraphEdit
4 participants
@Geometror @akien-mga @dustdfg @AThousandShips