-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow opening of polygon editor without texture #96731
Conversation
There's no reason to deny access to polygon editor when there's no texture set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Static analysis looking great.
I suppose this makes sense, but I wonder how user-friendly it is.
How does the UV editor look in this case? And it's a bit confusing IMO that one needs to click a "uv" button to open the "Polygon 2D UV Editor" to edit anything but UVs. |
See godotengine/godot-proposals#8209, which aims to solve this issue and more UX problems.
If there's a polygon, the outline (uv positions) are shown, just as with texture, but on a blank background: |
Maybe we could put a warning label that no texture is assigned? Probably more friendly than displaying empty editor window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine.
Usability improvements can be done later as well, empty editor is not the only problem tbh.
Thanks! |
For solving the "blank canvas" issue, here's 2 enhancements:
|
Gets rid of a nonsensical limitation. There's no reason to deny access to polygon editor when there's no texture set. While uv editor might not be very useful without texture (unless for custom shaders), the other editors are fully usable and useful regardless.