Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Use dotnet CLI to launch OpenVisualStudio.dll #97198

Conversation

raulsntos
Copy link
Member

Use the DLL instead of the EXE, so we can rely on the dotnet CLI handling the architecture.

⚠️ I don't have a Windows device, so testing is appreciated.

Use the DLL instead of the EXE, so we can rely on the dotnet CLI handling the architecture.
@raulsntos raulsntos added bug platform:windows needs testing topic:dotnet cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Sep 19, 2024
@raulsntos raulsntos added this to the 4.4 milestone Sep 19, 2024
@raulsntos raulsntos requested a review from a team as a code owner September 19, 2024 18:56
@paulloz
Copy link
Member

paulloz commented Sep 19, 2024

I'll install some version of VS to test this as soon as I can 😅 In any case, it looks like what we discussed earlier, so I expect it to be fine.

@paulloz
Copy link
Member

paulloz commented Sep 20, 2024

I installed Community 2022 this morning. I can reproduce the issue on dev, and this PR indeed fixes it. Nice one!

@akien-mga akien-mga changed the title C#: Use dotnet CLI to launch OpenVisualStudio.dll C#: Use dotnet CLI to launch OpenVisualStudio.dll Sep 20, 2024
@akien-mga akien-mga merged commit 2f078e5 into godotengine:master Sep 20, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/open-visual-studio-with-dotnet-cli branch September 20, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release platform:windows topic:dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on C# script does not launch Visual Studio anymore in 4.3
3 participants