Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GraphEdit] Only print warning for connection layer deletion when justified #97809

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[GraphEdit] Only print warning for connection layer deletion when justified #97809

merged 1 commit into from
Oct 4, 2024

Conversation

Geometror
Copy link
Member

Fixes #97772.

@Geometror Geometror added bug topic:editor regression topic:gui cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 4, 2024
@Geometror Geometror added this to the 4.4 milestone Oct 4, 2024
@Geometror Geometror requested a review from a team as a code owner October 4, 2024 11:30
@dustdfg
Copy link
Contributor

dustdfg commented Oct 4, 2024

Looks like it works. At least I don't see this warning anymore

Calinou
Calinou approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

@akien-mga akien-mga merged commit f6dbc04 into godotengine:master Oct 4, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release regression topic:editor topic:gui
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

GraphEdit's connection_layer removed warning when close editor
4 participants
@Geometror @dustdfg @akien-mga @Calinou