Partially revert #96780, remove warnings from project/editor settings _get
.
#97817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding
get_class_name()
checks (which only works for registered properties, but not for dynamic), removes warnings from project/editor settings_get
.If we want to keep these warnings, it won't be straightforward to do, since there is no fully functional
_has
equivalent for_get
/_set
and adding it will be a breaking change (or we can add a special exception forEditorSetting
andProjectSettings
). But these warnings are probably excessive, none of the other_get
overrides show any warnings, and GDScript documentation for_get
isreturn "null" if property is not handled by override
, so calling_get
for nonexistent property should not be considered abnormal.