Fix quick open background panel style #97820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Oct 4, 2024
|
Instead of copying tree panel, you can assign it directly in the dialog. There is no reason to have a type that's identical to existing one. CC @stijn-h |
passivestar
force-pushed
the
quick-open-bg
branch
from
9185161 to
08af57f
Compare
passivestar
changed the title
|
Thanks! |
|
Yeah, this is what it was supposed to look like. I intended to use this stylebox to remove padding on the sides of the dialog. I got it working in a hacky way, but ended up giving up on it because i couldnt figure it out and removed most theming, except this apparently. Thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick open result container tries to set the container stylebox override to
QuickOpenBackgroundPanelwhich isn't defined in the editor theme.This adds the missing stylebox to make quick open look consistent with all other lists in editor. Using Tree panel stylebox instead