-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node.xml: specify that normal processing happens in tree order #97905
Conversation
Thank you for fixing the typo! I found that my suggested change is incomplete, for |
Edit: When Priority is changed inside a process callback, the order will be wrong for this one iteration, then correct at the next iteration. That should be fine. |
I'd say this is a bit too complex to describe in the class docs here, and should be a detailed page in the docs instead, and linked to Related: |
I've removed it from the top paragraph since as you said that would get pretty long, mentioning both priority and tree order. Personally I would prefer to still add it to the actual method documentation, if only for parity with To be fully honest I don't have the knowledge, time, or motivation to create the full processing diagram requested in the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The commits need to be squashed into one before this can be merged. See here for one explanation on how to do do that. |
Thanks! |
For
_ready
it was already spelled out in a few places that it happens bottom to top (child first parent later).I found it hard to find information about the order of
_process
and_physics_process
, the only place I found was here in the tutorial for SceneTree which someone linked me to.