[WebSocket] Better detect transition to STATE_CLOSING #97913
+16
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When wslay receives a message that is too big it automatically sends a close request to the remote peer with code 1009 (Message Too Big) but it also completely stop calling the receive callback resulting in the state being "stuck" as CONNECTED (even if both client and server have disconnected). We now check if we sent such a close message and manually transition to the "closed" state with the proper reason.
Faless
force-pushed
the
fix/websocket_closing_transition
branch
from
ffc0929
to
a1ef068
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wslay receives a message that is too big it automatically sends a close request to the remote peer with code 1009 (Message Too Big) but it also completely stop calling the receive callback resulting in the state being "stuck" as CONNECTED (even if both client and server have disconnected).
We now check if we sent such a close message and manually transition to the "closed" state with the proper reason.
Fixes #97899
Fixes #84423