Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating dynamic objects in LightmapGI #97925

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

huwpascoe
Copy link
Contributor

@huwpascoe huwpascoe commented Oct 7, 2024

Fixes #77167

Minimal reproduction project: test_lightmapgi_dynamic_object_update.zip

image

@huwpascoe huwpascoe requested review from a team as code owners October 7, 2024 12:02
@Chaosus Chaosus added this to the 4.4 milestone Oct 7, 2024
@AThousandShips AThousandShips changed the title Lightmap Dynamic Bugfix Fix updating dynamic objects in LightmapGI Oct 7, 2024
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far. I think the approach right now is a bit hacky so I have left some comments about my concerns and how to address them.

scene/3d/lightmap_gi.cpp Outdated Show resolved Hide resolved
servers/rendering/renderer_scene_cull.cpp Outdated Show resolved Hide resolved
@huwpascoe huwpascoe force-pushed the lightmap_dynamic_bugfix branch from 1a53f43 to 274076c Compare October 17, 2024 15:28
@huwpascoe
Copy link
Contributor Author

Made the changes. It works for all three scenarios: scene load, visibility change, rebake.

@huwpascoe
Copy link
Contributor Author

Works with the new MRP #77167 (comment)

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for making the changes we discussed

@Repiteo Repiteo merged commit 5e65747 into godotengine:master Oct 21, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 21, 2024

Thanks! Congratulations on your first contribution!

@huwpascoe huwpascoe deleted the lightmap_dynamic_bugfix branch October 22, 2024 01:32
@atirut-w
Copy link
Contributor

Is this getting cherry picked?

@clayjohn
Copy link
Member

Is this getting cherry picked?

Good reminder. It wasn't tagged to be cherry picked. But I think it can be

@clayjohn clayjohn added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:rendering topic:3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LightmapGI: Dynamic objects don't update immediately after baking lightmaps or (re)loading a scene
5 participants