-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix updating dynamic objects in LightmapGI #97925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far. I think the approach right now is a bit hacky so I have left some comments about my concerns and how to address them.
1a53f43
to
274076c
Compare
Made the changes. It works for all three scenarios: scene load, visibility change, rebake. |
Works with the new MRP #77167 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for making the changes we discussed
Thanks! Congratulations on your first contribution! |
Is this getting cherry picked? |
Good reminder. It wasn't tagged to be cherry picked. But I think it can be |
Fixes #77167