Fix file logging log rotation #98216
Open
+175
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:core
cherrypick:4.2
AThousandShips
changed the title
pafuent
force-pushed
the
fixing_log_rotation
branch
from
bd18983 to
5013221
Compare
pafuent
force-pushed
the
fixing_log_rotation
branch
from
5013221 to
a94209d
Compare
|
Friendly remainder |
pafuent
force-pushed
the
fixing_log_rotation
branch
from
a94209d to
25ac8bc
Compare
Calinou
reviewed
Nov 19, 2024
Calinou
reviewed
Nov 19, 2024
tests/core/io/test_logger.h
Outdated
|
|
||
| namespace TestLogger { | ||
|
|
||
| const int sleep_duration = 1200000; |
There was a problem hiding this comment.
Suggested change
| const int sleep_duration = 1200000; | |
| constexpr int sleep_duration = 1200000; |
Also, can we use a shorter sleep duration? This is 1.2 seconds, which can impact test runtimes significantly since we test 6 rotations in total (8 seconds).
There was a problem hiding this comment.
I know 1.2 seconds is a lot, but the timestamp format that is added to the log files when are rotated is vformat("%sT%02d:%02d:%02d", timestamp, dt.hour, dt.minute, dt.second); which is up to seconds. So in order to get a new file name more than a second must pass between file rotations.
pafuent
force-pushed
the
fixing_log_rotation
branch
from
25ac8bc to
241a920
Compare
Fixes godotengine#97066 `RBSet` were used on `RotatedFileLogger` because it guarantees that iterating it is done via `operator<`. This is important because `RotatedFileLogger` depends on this behavior to delete the oldest log file. On godotengine#61194 `HashSet` was added and all `RBSet` uses were replaced by `HashSet`. When that happened, the iteration in order is guaranteed to be the insertion order, wich made that `RotatedFileLogger` delete the newest log file. As a bonus, I added unit test for `RotatedFileLogger` and `CompositeLogger`.
pafuent
force-pushed
the
fixing_log_rotation
branch
from
241a920 to
be2caf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97066
RBSetwere used onRotatedFileLoggerbecause it guarantees that iterating it is done viaoperator<. This is important becauseRotatedFileLoggerdepends on this behavior to delete the oldest log file.On #61194
HashSetwas added and allRBSetuses were replaced byHashSet.When that happened, the iteration in order is guaranteed to be the insertion order, wich made that
RotatedFileLoggerdelete the newest log file. As a bonus, I added unit test forRotatedFileLoggerandCompositeLogger.