Fix Android app permissions for SDK levels earlier than 28 #98230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
platform:android
topic:export
cherrypick:4.3
m4gr3d
approved these changes
Oct 17, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98229
The root of the problem is a change introduced in PermissionInfo in Android P. Before, the protection level consisted of the level itself and a set of flags. From Android P onwards, protection level and flags are queried separately. This is what Godot relies on currently to query what permissions the app needs and if they're currently granted. It fails for earlier Android versions because it doesn't separate the flags from the protection level before doing these checks.
This PR is backwards compatible and if accepted, I'd like it to be backported to Godot 4.3.