[3.x] Fix error when non-ASCII characters in resource pack path #98843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
timothyqiu
approved these changes
Nov 5, 2024
Co-authored-by: Haoyu Qiu <timothyqiu32@gmail.com>
kilian-diener
force-pushed
the
zip-path-utf8
branch
from
73e81c0 to
a75460f
Compare
AThousandShips
approved these changes
Nov 5, 2024
|
Thanks! |
akien-mga
added
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was fixed for version 4 in this PR: #78935
Cherry-picking for 3.x to fix the bug as well.