Fix clear_custom_color on invalid tree_item_inspected pointer
#99122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
clear_custom_color on invalid tree_item_inspected pointer #2clear_custom_color on invalid tree_item_inspected pointer
|
At the end of the drag and drop, the tree structure either changed or it didn't. |
|
Superseded by #99700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99111
In #96124 I centralized the code inside
NOTIFICATION_DRAG_END, which changed the order of operation causing a bug similar to (#93565) to resurface and preventing the earlier fix (#93576) to stay effective.Now I store the inspected & highlighted item as
Node *then retrieve the tree item from it, instead of storing it directly asTreeItem *which could become invalid if the tree order was modified.