-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying fade length in beats/bars/seconds #99188
base: master
Are you sure you want to change the base?
Allow specifying fade length in beats/bars/seconds #99188
Conversation
b72ed61
to
b8a2706
Compare
I changed the behavior of the options visibility and disabled state a bit to hide/disable controls that are not editing anything right now: Screencast.From.2024-11-13.23-05-12.mp4 |
b8a2706
to
84f2c78
Compare
2cad74e
to
19d2eb1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
19d2eb1
to
396c550
Compare
@RedMser Helped a lot, thank you! I hope my compat handling of the deprecated
|
396c550
to
3b3a0cb
Compare
Some thoughts about renaming the method
|
3b3a0cb
to
d6d300a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
8881a8b
to
8220636
Compare
Compat stuff looks good to me now, if the CI also does not complain 😉 |
8220636
to
bdd1ccf
Compare
@RedMser thanks a lot for the detailed explanation! 🙌 CI should be fine after the latest push 😄 |
a838335
to
59a5083
Compare
modules/interactive_music/doc_classes/AudioStreamInteractive.xml
Outdated
Show resolved
Hide resolved
modules/interactive_music/doc_classes/AudioStreamInteractive.xml
Outdated
Show resolved
Hide resolved
b2a432f
to
a6bbe09
Compare
Applied suggestions and squashed |
a6bbe09
to
ff0664a
Compare
This PR allows to pick between beats/bars/seconds for AudioStreamInteractive transition lengths.
Todo
Backwards compatibilityUpdate docs