Revert "Warn on unknown command line arguments" #99300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8379cc8. This caused some regressions, as this approach doesn't properly handle all possible arguments.
|
Was just about to report this as an issue! Glad to see a PR in for it! :) |
Repiteo
approved these changes
Nov 16, 2024
AThousandShips
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8379cc8.
This caused some regressions, as this approach doesn't properly handle all possible arguments.
-sparameter #99224.--generate-mono-glueprinting an unknown CLI argument warning #99294.I still think #98895 is a desirable change but it needs more work to handle things without false positives. We've tried several times in the past and it's not easy. I prefer we revert for now instead of adding hacks to work around the regressions.