Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persistent states for export with debug, as patch on editor restarts #99391

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Giganzo
Copy link
Contributor

@Giganzo Giganzo commented Nov 18, 2024

Fixes: #98754

@Giganzo Giganzo requested a review from a team as a code owner November 18, 2024 12:40
@Chaosus Chaosus added this to the 4.4 milestone Nov 18, 2024
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will finally put an end to a thorn in my side.

Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too familiar with this part of the code, but the codestyle checks out

@akien-mga
Copy link
Member

I tend to agree with this statement in the bug report:

In my humble opinion, this boolean shouldn't even be in the window there, but part of the export options, but that's perhaps more of a proposal than an issue report.

(Also with the fact that it's proposal material and thus not something to handle here.)

So until we do decide to change this, I agree with making the boolean on the export dialog persistent.

@Repiteo Repiteo merged commit a0cd8f1 into godotengine:master Nov 19, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 19, 2024

Thanks!

@Giganzo Giganzo deleted the export-debug branch November 25, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restarting editor resets "Export With Debug" option
5 participants