Add tooltips to dock menu and remove disabled items #99550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think not having them appear in the menu at all makes sense. The Script and 3D editor buttons also disappear when disabled. |
Mickeon
reviewed
Nov 22, 2024
kitbdev
force-pushed
the
add-dock-menu-tooltips
branch
from
9b6d1d2 to
2ebd1b6
Compare
Mickeon
approved these changes
Nov 22, 2024
kitbdev
force-pushed
the
add-dock-menu-tooltips
branch
from
2ebd1b6 to
b862a39
Compare
akien-mga
approved these changes
Nov 28, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed docks disabled in EditorFeatures from menu, instead of having them disabled (#89017 (comment))
I could alternatively keep them and add a tooltip if we want.
It will say 'Open the %s dock' if it is closed and 'Focus on the %s dock' if it is already open.
It's a little weird since they use the same text, the tooltip doesn't get moved when hovering over different items.