[Buildsystem] Fix path format for SCU builds on Windows #99629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Nov 24, 2024
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from:
_find_scu_section_namefunction with SCons builtins #98888Keeping the other changes for now unless it's better to just revert that, I think the cleanup otherwise is an improvement. Don't know if there might be better ways to achieve this particular fix but the method to just replace
\\with/is used elsewhere in this file so I think it's appropriate.Any additional ideas on how to solve this is very welcome, but does solve the problem for me
scu_build=yestakes the double of the time to compile in 4.4 dev 4 #99607