fix build for 3.4 #119
Merged
fix build for 3.4 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 2, 2022 13:36
|
Hello Not sure if you have any ideas of how to fix the Linux ubsan errors , but maybe that can be another pr |
added 2 commits
April 8, 2022 08:30
|
Thanks for your contribution! |
|
We'd better keep the quickjs/quickjs/VERSION.txt |
Sorry, I don't understand? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build works for me now.
also updated to work with new scons (it ignores .gen. files now unless added specifically)
I don't know github actions, I tried to add automatic publishing but I am not sure if it works.
Edit:
Added a file to copy the tests from Godot, this helps reduce the maintenance of the build environments (the previous script was very custom). There is still some specialization, for the ansan and ubsan builds of Linux (fails with Infinity/nan errors) and with windows (quickjs incompatible with msvc, must use mingw.).
I also added a script that should simplify this project's release process, now all you should need to do to update a new release is to tag/create a new release and everything should be uploaded to the release at the end of the build.
I'm sorry about the amount of commits, I don't know Windows, or JavaScript so there was a lot of trial and error. As long as we squash merge it should be okay.