Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

fix: replace compiled files of erc20 contract with right ones #131

Conversation

magicalne
Copy link
Contributor

The original files did not belong to SudtERC20Proxy_UserDefinedDecimals.sol.

@magicalne magicalne requested review from Flouse and zeroqn March 18, 2022 09:51
Copy link

@e00dan e00dan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment of "solidity/erc20/SudtERC20Proxy_UserDefinedDecimals.ContractCode.hex" fails. Are you able to deploy this contract on Godwoken Testnet v1?

@e00dan
Copy link

e00dan commented Mar 18, 2022

Existing code in https://github.com/nervosnetwork/godwoken-polyjuice/blob/compatibility-breaking-changes/solidity/erc20/SudtERC20Proxy_UserDefinedDecimals.bin is working fine.

➜  5-erc20-proxy git:(master) ✗ node transfer.js 
Testing SUDT-ERC20 proxy transfer on Nervos Layer 2 Testnet
Using Ethereum address: 0xD173313A51f8fc37BcF67569b463abd89d81844f
Deploying SUDT Proxy contract...
Deploy transaction hash: 0x755a8d9cbe11b829424c6eb2d0e2f950fa4f778d5d40c266ca9b55cab77c00d4
Deployed SUDT-ERC20 Proxy contract address: 0xc07D7eB1f799e25d837F01f1419BB90f4e3a9731
Checking SUDT balance...
Sender SUDT balance before transfer:  20
Receiver SUDT balance before transfer:  0
Try calling transfer before sending...
Try sending SUDT transfer...
Sender SUDT balance after transfer:  19
Receiver SUDT balance after transfer:  1

Demo code: https://github.com/nervosnetwork/layer2-evm-documentation/blob/master/code-examples/5-erc20-proxy/transfer.js

@magicalne
Copy link
Contributor Author

You're right. My mistake. I should update the abi file only. Thanks!

@magicalne magicalne force-pushed the fix_erc20_compiled_files branch from f9e5cbd to 13d0492 Compare March 21, 2022 03:28
@Flouse Flouse requested a review from e00dan March 21, 2022 03:36
@Flouse Flouse merged commit d19f1e7 into godwokenrises:compatibility-breaking-changes Mar 22, 2022
Flouse pushed a commit that referenced this pull request Apr 14, 2022
* fix: replace compiled files of erc20 contract with right ones
@magicalne magicalne deleted the fix_erc20_compiled_files branch September 23, 2022 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants