This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
feat: add overwrite param when update eth addr reg #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyr
approved these changes
May 9, 2022
Flouse
approved these changes
May 9, 2022
Flouse
suggested changes
May 10, 2022
magicalne
force-pushed
the
fix_addr_collision
branch
from
e5ed636 to
05fc487
Compare
magicalne
force-pushed
the
fix_addr_collision
branch
from
05fc487 to
4c7ec03
Compare
Done. |
jjyr
approved these changes
May 11, 2022
|
We can clear the existed mapping record when overwrite is true, thus, we do not need to call another method. I have pushed a commit to do this please review @magicalne |
Flouse
approved these changes
May 11, 2022
Flouse
added a commit
to Flouse/godwoken-docker-prebuilds
that referenced
this pull request
May 11, 2022
GODWOKEN_REF := develop GODWOKEN_SCRIPTS_REF := refs/pull/119/merge # godwokenrises/godwoken-scripts#119
zeroqn
approved these changes
May 11, 2022
Flouse
added a commit
to Flouse/godwoken-docker-prebuilds
that referenced
this pull request
Jun 6, 2022
GODWOKEN_REF := develop GODWOKEN_SCRIPTS_REF := refs/pull/119/merge # godwokenrises/godwoken-scripts#119
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
overwriteparam when updating mapping between eth addr and script hash. So that we can choose to overwrite mapping or not if there is an address collision.