Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump deps version for contract-tests #180

Merged
merged 1 commit into from
Aug 31, 2022
Merged

build: bump deps version for contract-tests #180

merged 1 commit into from
Aug 31, 2022

Conversation

ShookLyngs
Copy link
Contributor

@ShookLyngs ShookLyngs commented Aug 30, 2022 •
edited
Loading

Issues and fixes:

  • ethers > 5.6.1 has a problem with hardhat's revert info, which will fail some of our tests
  • The PR can temporary prevent the issue by locking the version of ethers from "ethers": "^5.4.1" to "ethers": "5.6.1"
  • The PR also updates some other dependencies' version

Reference:

@ShookLyngs ShookLyngs requested a review from Flouse August 30, 2022 15:23
@ShookLyngs ShookLyngs changed the title build: bump deps version for contracts build: bump deps version for contract-tests Aug 31, 2022
@Flouse Flouse requested a review from felicityin August 31, 2022 03:15
@Flouse Flouse merged commit 2b99e2e into develop Aug 31, 2022
@Flouse Flouse deleted the build-contracts-deps branch August 31, 2022 03:38
@ShookLyngs ShookLyngs mentioned this pull request Aug 31, 2022
Closed
Flouse pushed a commit that referenced this pull request Sep 7, 2022
@ShookLyngs @Flouse
build: bump deps version for contracts (#180)
4e72518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felicityin felicityin felicityin approved these changes

@Flouse Flouse Flouse approved these changes

Assignees

@ShookLyngs ShookLyngs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShookLyngs @Flouse @felicityin