This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
refactor: handling godwoken error #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keroro520
force-pushed
the
revert-error
branch
from
3a479bd to
fc9ba1b
Compare
RetricSu
reviewed
Sep 8, 2022
RetricSu
approved these changes
Sep 8, 2022
|
Can hardhat parse error message after |
If HardHat fails after Godwoken-tests has several cases that trigger revert-error: https://github.com/nervosnetwork/godwoken-tests/pull/179/files |
Flouse
suggested changes
Sep 8, 2022
Flouse
approved these changes
Sep 9, 2022
keroro520
force-pushed
the
revert-error
branch
from
a7abecd to
526fbe7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main contribution:
Fix [v1.3] hardhat cannot parse eth_call failed information #423
Refactor handling of godwoken error.
Because the
gw-errormodule has been almost rewritten, I suggest reviewers read the file directly: https://github.com/nervosnetwork/godwoken-web3/blob/fc9ba1bced40ac38ecc2f5b4a7bd033952540a45/packages/api-server/src/methods/gw-error.tsRemove
error.data.failed_reasonanderror.data.messagefrom error JSONRPC response.See also: Simplify the error response #511
Others:
Err("can't find backend for script_hash")UNPREDICTABLE_GAS_LIMITprefix from error response ofeth_estimateGas