refactor: base on reviews

godwokenrises · Dec 12, 2021 · ccd427c · ccd427c
1 parent 6ad7c5d
commit ccd427c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/crates/mem-pool/src/pool.rs b/crates/mem-pool/src/pool.rs
@@ -210,7 +210,7 @@ impl MemPool {
         self.mem_block.txs().len().saturating_add(expect_slots) > MAX_MEM_BLOCK_TXS
     }
 
-    pub fn pending_restored_txc_hashes(&mut self) -> &mut Vec<H256> {
+    pub fn pending_restored_tx_hashes(&mut self) -> &mut Vec<H256> {
         &mut self.pending_restored_tx_hashes
     }
 

diff --git a/crates/rpc-server/src/registry.rs b/crates/rpc-server/src/registry.rs
@@ -346,9 +346,9 @@ impl RequestSubmitter {
 
             log::info!(
                 "reinject mem block txs {}",
-                mem_pool.pending_restored_txc_hashes().len()
+                mem_pool.pending_restored_tx_hashes().len()
             );
-            while let Some(hash) = mem_pool.pending_restored_txc_hashes().last().cloned() {
+            while let Some(hash) = mem_pool.pending_restored_tx_hashes().pop() {
                 match db.get_mem_pool_transaction(&hash) {
                     Ok(Some(tx)) => {
                         if let Err(err) = mem_pool.push_transaction(tx) {
@@ -362,8 +362,6 @@ impl RequestSubmitter {
                         log::error!("reinject mem block tx {} err {}", hash.pack(), err);
                     }
                 }
-
-                mem_pool.pending_restored_txc_hashes().pop();
             }
         }