Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove some zero address limit #1008

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Conversation

classicalliu
Copy link
Contributor

@classicalliu classicalliu commented Feb 28, 2023

And using zero address as default from if exists

When call

{
    "id": 2,
    "jsonrpc": "2.0",
    "method": "eth_getTransactionCount",
    "params": [
        "0x0000000000000000000000000000000000000000",
        "latest"
    ]
}

Before

{
    "jsonrpc": "2.0",
    "id": 2,
    "error": {
        "code": -32099,
        "message": "zero address 0x0000000000000000000000000000000000000000 has no valid account_id! more info: https://github.com/nervosnetwork/godwoken-web3/blob/main/docs/compatibility.md"
    }
}

After

{
    "jsonrpc": "2.0",
    "id": 2,
    "result": "0x"
}

And using zero address as default from if exists
@Flouse Flouse requested review from RetricSu and a team February 28, 2023 15:38
For web3 unit tests will run all tests
zeroqn
zeroqn previously approved these changes Mar 1, 2023
@Flouse Flouse requested a review from a team March 1, 2023 08:45
Copy link
Contributor

@RetricSu RetricSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@classicalliu
Copy link
Contributor Author

https://github.com/godwokenrises/godwoken/blob/develop/web3/docs/compatibility.md I think the first item should be removed too

Removed, thx

Flouse added a commit to godwokenrises/godwoken-doc that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants