fix(polyjuice): native transfer needs check gas limit before pay fee #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroqn
approved these changes
Mar 6, 2023
Flouse
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
I think this change requires a new poly_backend_fork, right?
@magicalne
Yes, this change is not compatible. |
jjyr
approved these changes
Mar 22, 2023
cc @Simon-Tl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native transferring doesn't check the actual gas used. This makes it happens that charging more fee than the gas limit. Or in another sense, the gas limit is ignored. This occurs when transferring to an unregistered address.
We can fix this by comparing
gas_usedandgas_limitbefore paying the fee.