Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure tip block and epoch are consistent #596

Merged
merged 2 commits into from
Mar 7, 2022
Merged

fix: make sure tip block and epoch are consistent #596

merged 2 commits into from
Mar 7, 2022

Conversation

keroro520
Copy link
Contributor

I think GLOBAL_CURRENT_EPOCH_NUMBER and GLOBAL_VM_VERSION should match tip block. And we can extract the tip's corresponding epoch info from the block header.

@Flouse Flouse requested review from magicalne and jjyr February 24, 2022 07:12
@Flouse
Copy link
Collaborator

Flouse commented Mar 7, 2022

@keroro520
Please cherry-pick this PR to compatibility-breaking-changes branch.

@Flouse Flouse merged commit 15e3b2a into godwokenrises:develop Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flouse Flouse Flouse approved these changes

@jjyr jjyr jjyr approved these changes

@magicalne magicalne magicalne approved these changes

@zeroqn zeroqn zeroqn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@keroro520 @Flouse @jjyr @magicalne @zeroqn