Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fast withdrawal to v1 #645

Merged
merged 17 commits into from
Apr 27, 2022
Merged

feat: fast withdrawal to v1 #645

merged 17 commits into from
Apr 27, 2022

Conversation

zeroqn
Copy link
Contributor

@zeroqn zeroqn commented Apr 6, 2022 •
edited
Loading

  • support generate and unlock withdrawal to v1 cell
  • add withdrawal config
pub struct WithdrawalToV1Config {
    pub v1_rollup_type_hash: H256,
    pub v1_deposit_lock_code_hash: H256,
    pub v1_eth_lock_code_hash: H256,
    pub v1_deposit_minimal_cancel_timeout_msecs: u64,
}
  • add withdraw-to-v1 command to gw-tools

@zeroqn zeroqn marked this pull request as ready for review April 7, 2022 09:22
@zeroqn zeroqn force-pushed the feat-fast-withdrawal-to-v1 branch from 7c7d55f to 648f840 Compare April 7, 2022 10:17
@Flouse Flouse requested review from jjyr, blckngm and Flouse April 7, 2022 15:35
blckngm
blckngm reviewed Apr 8, 2022
View reviewed changes
crates/block-producer/src/withdrawal.rs Outdated Show resolved Hide resolved
crates/rpc-client/src/withdrawal.rs Outdated Show resolved Hide resolved
@zeroqn zeroqn force-pushed the feat-fast-withdrawal-to-v1 branch 2 times, most recently from 118b704 to 210f592 Compare April 18, 2022 07:29
@zeroqn zeroqn force-pushed the feat-fast-withdrawal-to-v1 branch 3 times, most recently from 6585fd6 to 4b93d64 Compare April 20, 2022 12:45
Flouse
Flouse requested changes Apr 24, 2022
View reviewed changes
.github/workflows/rust.yml Outdated Show resolved Hide resolved
@Flouse Flouse mentioned this pull request Apr 24, 2022
Merged
zeroqn and others added 16 commits April 26, 2022 19:00
@zeroqn
fix(types): move DepositInfo conversion to mem_block.rs
77bdb40 
std
@zeroqn
feat(types): Add withdraw_to_v1 to WithdrawalRequestExtra
fa04ba3
@zeroqn
feat(generator): support generate withdrawal to v1 cell
dbd716d
@zeroqn
feat(rpc): support query withdrawal to v1 withdrawal cell
f056092
@zeroqn
feat(block-producer): unlock withdrawal to v1 cell
010a055
@zeroqn
test(withdrawal): unlock withdrawal to v1 cell
829d522
@zeroqn
feat(rpc): verify withdrawal to v1 request
2ecfa95
@zeroqn
feat(tools): withdraw-to-v1 command
4741904
@zeroqn
chore(devtools): switch to feature prebuilds
bad7f2e
@zeroqn
chore: base on review
8163d28
@zeroqn
fix clippy warnings
58b5617
@zeroqn
chore(types): update V1DepositLockArgs to v1.1
5c579f1
@zeroqn
feat: upgrade to v1.1 DepositLockArgs
3872584
@keroro520 @zeroqn
fix: workaround for tx temporally disappear after send_transaction
7f84f87
@zeroqn
fix(ci): don't merge pr commit into default branch
cd10d41 
Cause strange clippy/test failure
@zeroqn
rebase to latest commit
350105c
@zeroqn zeroqn force-pushed the feat-fast-withdrawal-to-v1 branch from c33e49f to 350105c Compare April 26, 2022 11:03
jjyr
jjyr requested changes Apr 27, 2022
View reviewed changes
crates/block-producer/src/withdrawal.rs Show resolved Hide resolved
crates/tools/src/main.rs Show resolved Hide resolved
@zeroqn zeroqn force-pushed the feat-fast-withdrawal-to-v1 branch from 81df540 to 43b7427 Compare April 27, 2022 10:26
@jjyr jjyr requested review from Flouse and blckngm April 27, 2022 10:30
@Flouse Flouse merged commit fe0ab68 into godwokenrises:0.10 Apr 27, 2022
@Flouse Flouse mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckngm blckngm blckngm approved these changes

@jjyr jjyr jjyr approved these changes

@Flouse Flouse Flouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zeroqn @Flouse @jjyr @blckngm @keroro520