New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sudt with registry address #649

Merged

jjyr merged 39 commits into godwokenrises:develop from jjyr:refactor-sudt-with-registry-address

Apr 18, 2022

Collaborator

jjyr commented Apr 6, 2022 •

edited by Flouse

Loading

Related PRs

jjyr mentioned this pull request

Refactor sudt with registry address godwokenrises/godwoken-scripts#116

Merged

blckngm reviewed

View reviewed changes

docs/CHANGES.md Outdated Show resolved Hide resolved

blckngm reviewed

View reviewed changes

docs/CHANGES.md Outdated Show resolved Hide resolved

blckngm reviewed

View reviewed changes

docs/CHANGES.md Outdated Show resolved Hide resolved

blckngm reviewed

View reviewed changes

docs/CHANGES.md Outdated Show resolved Hide resolved

blckngm reviewed

View reviewed changes

docs/CHANGES.md Outdated Show resolved Hide resolved

blckngm reviewed

View reviewed changes

docs/CHANGES.md Outdated Show resolved Hide resolved

blckngm reviewed

View reviewed changes

docs/CHANGES.md Outdated Show resolved Hide resolved

blckngm reviewed

View reviewed changes

docs/CHANGES.md Outdated Show resolved Hide resolved

blckngm reviewed

View reviewed changes

docs/CHANGES.md Outdated Show resolved Hide resolved

blckngm reviewed

View reviewed changes

docs/CHANGES.md Outdated Show resolved Hide resolved

blckngm reviewed

View reviewed changes

docs/CHANGES.md Outdated Show resolved Hide resolved

blckngm reviewed

View reviewed changes

docs/CHANGES.md Outdated Show resolved Hide resolved

Flouse requested review from zeroqn and magicalne

April 7, 2022 16:47

Flouse added a commit to Flouse/godwoken-docker-prebuilds that referenced this pull request


          GODWOKEN_REF := refs/pull/649/head & GODWOKEN_SCRIPTS_REF := refs/pul…

192cb34

…l/116/head

- godwokenrises/godwoken#649
- godwokenrises/godwoken-scripts#116

blckngm reviewed

View reviewed changes

crates/common/src/registry_address.rs Outdated Show resolved Hide resolved

blckngm reviewed

View reviewed changes

crates/common/src/registry_address.rs Show resolved Hide resolved

zeroqn previously approved these changes

View reviewed changes

crates/generator/src/account_lock_manage/eip712/types.rs Show resolved Hide resolved

magicalne previously approved these changes

View reviewed changes

jjyr dismissed stale reviews from magicalne and zeroqn via

389ca01

April 13, 2022 05:32

jjyr force-pushed the refactor-sudt-with-registry-address branch from 389ca01 to e7be075 Compare

April 13, 2022 05:43

Flouse mentioned this pull request

Adapt Godwoken v1.1 godwokenrises/godwoken-kicker#221

Merged

jjyr added 6 commits

April 14, 2022 15:31


          refactor: Support registry address

cb72186


          refactor: Add registry_id to builtin scripts structure

8863d8d


          refactor: fix gw-common reference

311bf56


          refactor: Add registry_id to DepositLockArgs


          feat: Handling EOA ETH address mapping in deposit

1c157ba


          feat: try to extract eth address before handle deposit

972d6cb

Flouse and others added 9 commits

April 14, 2022 15:46


          Deprecate EOA mapping crate

242d2e1


          chore: update the refs of integration-test

6eab630


          Refactor create_creator_account in gw-tools

35f2ccc


          fix(tool): use EIP-712 typed message in create_creator_account

c0e7c6d

ErrMsg:
1. failed Unlock error Invalid signature: Wrong chain_id, expected: 71400 actual: 0
2. Invalid signature: Mismatch pubkey hash


          fix: check registry address len to prevent panic

f6651ee


          fix: fix jsonrpc types

5d081c9


          chore: add arg block-producer-address to generate-config command

1d1952a


          chore: update kicker ref in integration tests

8eb3a93


          chore: rebase develop

fdfd7d1

jjyr force-pushed the refactor-sudt-with-registry-address branch from 0783572 to fdfd7d1 Compare

April 14, 2022 07:52

Collaborator Author

jjyr commented Apr 14, 2022

Rebased

jjyr requested review from blckngm, zeroqn and magicalne

April 14, 2022 07:53


          fix: fix bench tests

6180f04

keroro520 reviewed

View reviewed changes

crates/types/src/offchain/pool.rs Show resolved Hide resolved

crates/types/schemas/godwoken.mol Show resolved Hide resolved

keroro520 previously approved these changes

View reviewed changes

Contributor

keroro520 left a comment

LGTM

Contributor

blckngm commented Apr 15, 2022

FeeQueue benchmark test is failing. Otherwise LGTM.


          fix: fix fee_queue benchmark

872ea60

jjyr dismissed keroro520’s stale review via

872ea60

April 15, 2022 03:39

Collaborator Author

jjyr commented Apr 15, 2022

Fixed the benchmark test. @sopium @keroro520

blckngm previously approved these changes

View reviewed changes


          chore: upgrade integration tests kicker_ref to v1.1

a62744b

jjyr dismissed blckngm’s stale review via

a62744b

April 15, 2022 07:41

zeroqn reviewed

View reviewed changes

crates/tools/src/account.rs Outdated Show resolved Hide resolved


          fix: fix parse_account_from_str

66f6621

zeroqn approved these changes

View reviewed changes

jjyr merged commit b4db765 into godwokenrises:develop

jjyr deleted the refactor-sudt-with-registry-address branch

April 18, 2022 02:02

jjyr restored the refactor-sudt-with-registry-address branch

April 18, 2022 03:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet