feat: get in queue requests #655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blckngm
force-pushed
the
get-in-queue-transactions
branch
from
ec5c5c1 to
1d880fd
Compare
blckngm
force-pushed
the
get-in-queue-transactions
branch
from
0c7449f to
21642dc
Compare
Now the `gw_get_transaction`/`gw_get_withdrawal` RPC calls will return
```
{ "status": "in_queue", ... }
```
instead of null for in queue transactions/withdrawals.
On a full node `gw_get_transaction`/`gw_get_withdrawal` will be almost
always accurate.
Readonly nodes when well connected to the full node via the p2p network
will be notified about in queue request changes, so they will also
return
```
{ "status": "in_queue", ... }
```
for requests that **they know** are in queue.
But due to network delay or connectivity issues they may still return
inaccurate answers, e.g. they may return null for some in queue
requests, or they may return “in queue” or null for actually
pending/committed requests.
FeeQueue is not shared with any other tasks. It does not need to be wrapped with Arc Mutex.
blckngm
force-pushed
the
get-in-queue-transactions
branch
from
21642dc to
106781f
Compare
|
This PR introduce too many cost to the protocol compares to the benefit. We should give a better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the
gw_get_transaction/gw_get_withdrawalRPC calls will returninstead of null for in queue transactions/withdrawals.
On a full node
gw_get_transaction/gw_get_withdrawalwill be almostalways accurate.
Readonly nodes when well connected to the full node via the p2p network
will be notified about in queue request changes, so they will also
return
for requests that they know are in queue.
But due to network delay or connectivity issues they may still return
inaccurate answers, e.g. they may return null for some in queue
requests, or they may return “in queue” or null for actually
pending/committed requests.