Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tx verification #677

Merged
merged 5 commits into from
Apr 27, 2022
Merged

Refactor tx verification #677

merged 5 commits into from
Apr 27, 2022

Conversation

jjyr
Copy link
Collaborator

@jjyr jjyr commented Apr 26, 2022

  1. Move tx & withdrawal verification code to a standalone module.
  2. Reject tx if sender's balance is insufficient.

magicalne
magicalne previously approved these changes Apr 26, 2022
View reviewed changes
blckngm
blckngm reviewed Apr 26, 2022
View reviewed changes
crates/generator/src/typed_transaction/types.rs Outdated Show resolved Hide resolved
crates/tests/src/testing_tool/chain.rs Outdated Show resolved Hide resolved
crates/generator/src/typed_transaction/types.rs Outdated Show resolved Hide resolved
crates/generator/src/typed_transaction/types.rs Outdated Show resolved Hide resolved
crates/generator/src/typed_transaction/types.rs Outdated Show resolved Hide resolved
@jjyr jjyr requested review from blckngm and magicalne April 26, 2022 10:44
@jjyr jjyr requested a review from blckngm April 27, 2022 03:43
@jjyr jjyr merged commit 3059269 into godwokenrises:develop Apr 27, 2022
@jjyr jjyr deleted the refactor-tx-verification branch April 27, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicalne magicalne magicalne approved these changes

@blckngm blckngm blckngm approved these changes

@zeroqn zeroqn zeroqn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjyr @magicalne @blckngm @zeroqn